This is an automated email from the ASF dual-hosted git repository.
markt-asf pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 39f7e99bc4 Additional guards for a null Manager
39f7e99bc4 is described below
commit 39f7e99bc48d4df854afcc764b15165170cbafbc
Author: Mark Thomas <[email protected]>
AuthorDate: Fri May 22 19:03:25 2026 +0100
Additional guards for a null Manager
---
java/org/apache/catalina/manager/HTMLManagerServlet.java | 7 ++++++-
java/org/apache/catalina/manager/ManagerServlet.java | 8 ++++++--
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/java/org/apache/catalina/manager/HTMLManagerServlet.java
b/java/org/apache/catalina/manager/HTMLManagerServlet.java
index a2a97bf88b..eb90555729 100644
--- a/java/org/apache/catalina/manager/HTMLManagerServlet.java
+++ b/java/org/apache/catalina/manager/HTMLManagerServlet.java
@@ -890,7 +890,12 @@ public class HTMLManagerServlet extends ManagerServlet {
smClient.getString("managerServlet.noContext",
Escape.htmlElementContent(cn.getDisplayName())));
}
Manager manager = ctxt.getManager();
- List<Session> sessions = new
ArrayList<>(Arrays.asList(manager.findSessions()));
+ List<Session> sessions;
+ if (manager == null) {
+ sessions = Collections.emptyList();
+ } else {
+ sessions = new ArrayList<>(Arrays.asList(manager.findSessions()));
+ }
if (manager instanceof DistributedManager && showProxySessions) {
// Add dummy proxy sessions
Set<String> sessionIds = ((DistributedManager)
manager).getSessionIdsFull();
diff --git a/java/org/apache/catalina/manager/ManagerServlet.java
b/java/org/apache/catalina/manager/ManagerServlet.java
index b7e45516aa..4ff7ae09ce 100644
--- a/java/org/apache/catalina/manager/ManagerServlet.java
+++ b/java/org/apache/catalina/manager/ManagerServlet.java
@@ -1051,8 +1051,12 @@ public class ManagerServlet extends HttpServlet
implements ContainerServlet {
}
List<String> parts;
if (context.getState().isAvailable()) {
- parts = Arrays.asList(displayPath, "running", "" +
context.getManager().findSessions().length,
- context.getDocBase());
+ int sessionCount = 0;
+ Manager manager = context.getManager();
+ if (manager != null) {
+ sessionCount = manager.findSessions().length;
+ }
+ parts = Arrays.asList(displayPath, "running", "" +
sessionCount, context.getDocBase());
} else {
parts = Arrays.asList(displayPath, "stopped", "0",
context.getDocBase());
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
