On 27/05/2026 20:31, Rémy Maucherat wrote:
On Wed, May 27, 2026 at 6:54 PM <[email protected]> wrote:
This is an automated email from the ASF dual-hosted git repository.
markt-asf pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 7b8ac34e50 Restore short-circuit behaviour where required.
7b8ac34e50 is described below
commit 7b8ac34e50742b147ff98f38c4c0ec8947a45dbe
Author: Mark Thomas <[email protected]>
AuthorDate: Wed May 27 17:53:24 2026 +0100
Restore short-circuit behaviour where required.
<snip/>
Good thing you caught this one. I see the trick was added 20 years
ago, and I never really paid attention to it. This does not seem to be
something that my model understands very well, it's likely not used
too much around.
Shouldn't we rewrite it as "hasEvents = events() ? : true : hasEvents"
or something like that ?
Possibly. I wasn't sure if re-writing it would be clearer or as
performant so I went with the option of adding a comment.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
