This is an automated email from the ASF dual-hosted git repository.
markt-asf pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new ebe9c0ca20 %{SSL:HTTPS} should return either on or off
ebe9c0ca20 is described below
commit ebe9c0ca200af67668ae8b9eabf99426cbe25f21
Author: Mark Thomas <[email protected]>
AuthorDate: Thu May 28 17:26:37 2026 +0100
%{SSL:HTTPS} should return either on or off
---
java/org/apache/catalina/valves/rewrite/ResolverImpl.java | 4 +++-
webapps/docs/changelog.xml | 5 +++++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/java/org/apache/catalina/valves/rewrite/ResolverImpl.java
b/java/org/apache/catalina/valves/rewrite/ResolverImpl.java
index 4747021286..b058655224 100644
--- a/java/org/apache/catalina/valves/rewrite/ResolverImpl.java
+++ b/java/org/apache/catalina/valves/rewrite/ResolverImpl.java
@@ -144,7 +144,7 @@ public class ResolverImpl extends Resolver {
// SSL_SRP_USER: no planned support for SRP
// SSL_SRP_USERINFO: no planned support for SRP
if (key.equals("HTTPS")) {
- return String.valueOf(sslSupport != null);
+ return "on";
} else if (key.equals("SSL_PROTOCOL")) {
return sslSupport.getProtocol();
} else if (key.equals("SSL_SESSION_ID")) {
@@ -222,6 +222,8 @@ public class ResolverImpl extends Resolver {
containerLog.debug(sm.getString("resolverImpl.tlsError"),
ioe);
}
}
+ } else if (key.equals("HTTPS")) {
+ return "off";
}
return null;
}
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index bbbbec2d22..3cb2bd072b 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -314,6 +314,11 @@
<fix>
Fix connection leak in <code>ProxyErrorReportValve</code>. (remm)
</fix>
+ <fix>
+ When using the <code>RewriteValve</code>, <code>%{SSL:HTTPS}</code> now
+ returns <code>on</code> or <code>off</code> rather than
+ <code>true</code> or <code>false</code> to align with httpd. (markt)
+ </fix>
</changelog>
</subsection>
<subsection name="Coyote">
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
