On 03/06/2026 11:31, Rémy Maucherat wrote:
On Wed, Jun 3, 2026 at 10:23 AM Mark Thomas <[email protected]> wrote:
On 03/06/2026 08:31, Rémy Maucherat wrote:
Hi,
I'm through the first full code review.
Excellent. I'm around a day behind you reviewing the changes.
Some notes:
- I did not look much at the issues for some components. This includes
clustering, bcel, fileupload, dbcp, pool, some websockets.
I'm less concerned about bcel, fileupload, dbcp and pool since any
issues need to be addressed in Commons for us to pick up.
- I'm now processing another full code review.
- I skipped over cosmetic and low issues the first time, and issues
for some components. I'll do things more thoroughly this time since
there's less urgency.
Ack.
As we get close to the tags we might need a short quiet period just to
give us a chance to make sure all the changes are reviewed and the tests
all pass before we tag.
Ok, so no more commits for now ;)
While I was suggesting a pause in the commits as a result of the code
review, I wasn't suggesting an immediate pause. I think we are probably
OK until the Commons Daemon update is committed as that is the one I am
not sure of the timescale for.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
