This is an automated email from the ASF dual-hosted git repository. ChristopherSchultz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git
commit 0d66c7de334162f50bdc7163600ada2d418966cc Author: Christopher Schultz <[email protected]> AuthorDate: Mon Jun 8 11:56:20 2026 -0400 Use snprintf when printing port numbers Also use the correct conversion for port numbers (n->h not h->n) --- native/common/jk_connect.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/native/common/jk_connect.c b/native/common/jk_connect.c index 58172a9e7..839e530ab 100644 --- a/native/common/jk_connect.c +++ b/native/common/jk_connect.c @@ -1329,13 +1329,13 @@ char *jk_dump_sinfo(jk_sock_t sd, char *buf, size_t size) if (lsaddr.sa_family == JK_INET) { struct sockaddr_in *sa = (struct sockaddr_in *)&lsaddr; inet_ntop4((unsigned char *)&sa->sin_addr, buf, size); - sprintf(pb, ":%d", (unsigned int)htons(sa->sin_port)); + snprintf(pb, sizeof(pb), ":%d", (unsigned int)ntohs(sa->sin_port)); } #if JK_HAVE_IPV6 else { struct sockaddr_in6 *sa = (struct sockaddr_in6 *)&lsaddr; inet_ntop6((unsigned char *)&sa->sin6_addr, buf, size); - sprintf(pb, ":%d", (unsigned int)htons(sa->sin6_port)); + snprintf(pb, sizeof(pb), ":%d", (unsigned int)ntohs(sa->sin6_port)); } #endif ps = strlen(buf); @@ -1346,13 +1346,13 @@ char *jk_dump_sinfo(jk_sock_t sd, char *buf, size_t size) if (rsaddr.sa_family == JK_INET) { struct sockaddr_in *sa = (struct sockaddr_in *)&rsaddr; inet_ntop4((unsigned char *)&sa->sin_addr, buf + ps, size - ps); - sprintf(pb, ":%d", (unsigned int)htons(sa->sin_port)); + snprintf(pb, sizeof(pb), ":%d", (unsigned int)ntohs(sa->sin_port)); } #if JK_HAVE_IPV6 else { struct sockaddr_in6 *sa = (struct sockaddr_in6 *)&rsaddr; inet_ntop6((unsigned char *)&sa->sin6_addr, buf + ps, size - ps); - sprintf(pb, ":%d", (unsigned int)htons(sa->sin6_port)); + snprintf(pb, sizeof(pb), ":%d", (unsigned int)ntohs(sa->sin6_port)); } #endif strncat(buf, pb, size - strlen(buf) - 1); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
