orbisai0security commented on PR #13: URL: https://github.com/apache/tomcat-connectors/pull/13#issuecomment-4665615991
Thank you for the detailed review. This is genuinely helpful feedback. You're right on all counts. I should have done a more thorough analysis of the actual exploit preconditions before labelling this CRITICAL; the rewrite rule context significantly limits real-world impact, and I overstated the severity. The `malloc` → `calloc` changes were unnecessary noise, and I missed both the unhandled allocation failures and the memory leak, ironically making the code worse in some respects while trying to improve it. If there's still appetite for the hardening change (minus the noise), I'm happy to resubmit a minimal, focused patch that only addresses the bounds check and properly handles allocation failures. But I'll defer to your judgment on whether that's worth the churn. Appreciate you taking the time to close this with an explanation rather than just rejecting it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
