markt-asf commented on code in PR #1030:
URL: https://github.com/apache/tomcat/pull/1030#discussion_r3655193178
##########
java/org/apache/catalina/core/StandardContext.java:
##########
@@ -4733,9 +4733,8 @@ private void addInjectionTarget(Injectable resource,
Map<String,Map<String,Strin
private void mergeParameters() {
Map<String,String> mergedParams = new HashMap<>();
- String[] names = findParameters();
- for (String s : names) {
- mergedParams.put(s, findParameter(s));
+ for (Map.Entry<String,String> parameter : parameters.entrySet()) {
+ mergedParams.put(parameter.getKey(), parameter.getValue());
Review Comment:
This could have used `Map.putAll(Map)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
