csutherl opened a new pull request, #1051: URL: https://github.com/apache/tomcat/pull/1051
`TesterOcspResponder` binds to a fixed port, 8888 (which is baked into the test certificates' AIA extension), so it cannot start when another process is already using that port. The existing `Assume.assumeNotNull(ocspResponder)` guard was not enough because the field was assigned before `start()` was called and the bind failure was only printed, leaving the field non-null and causing all tests to fail during the TLS handshake. This change only assigns `ocspResponder` on a successful start. On a `BindException`, we leave the field `null` so the tests are skipped as an environmental issue rather than failing. Any other startup failure is rethrown so genuine responder bugs are not masked. Submitting a PR to get consensus on whether or not this is the correct behavior, or if we feel a failure is appropriate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
