On 16/09/2026 09:40, Rémy Maucherat wrote:
On Wed, Sep 16, 2026 at 10:15 AM Mark Thomas <[email protected]> wrote:

On 14/09/2026 22:24, [email protected] wrote:
This is an automated email from the ASF dual-hosted git repository.

rmaucher pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
       new 5578eb98c1 Unescape quoted strings
5578eb98c1 is described below

commit 5578eb98c185d38f76b03af1994cc515892e2813
Author: remm <[email protected]>
AuthorDate: Mon Sep 14 23:24:29 2026 +0200

      Unescape quoted strings

Which version of JavaCC are you using to generate the parser? I am
trying to fix an issue around double-decoding with unicode escaped '\'
and can't seem to recreate the same output given the current jjt file.

Oops. So this is direct editing (which is bad, but it seemed
straightforward).

Makes sense. It is a lot quicker than running through the code generation cycle.

Rationale for the change: the JSON was written
escaped, so expecting to read it back unescaped did not seem
unreasonable.

I completely agree.

A unicode escaped '\' seems unlikely in the one place the JSONParser is used but it isn't impossible which usually means there will eventually be a user that trips over this.

I figured out the large differences I was seeing in generated code. I just needed to skip jjtree and use javacc directly on the jjt file.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to