markt-asf commented on PR #1070: URL: https://github.com/apache/tomcat/pull/1070#issuecomment-5757935893
The current key/cert generation is not run on every test. It runs every couple of years when the certs expire or sooner if we need to expand the set of test keys/certs. My point was that a PR that adds text keys and certs with no way to regenerate them is setting us up for a future set of test failures. This PR should add to the existing generation script but can't (at least directly) because that script is in a private repository. My suggestion was to move that script to this repo. That is a little more complex than I'd like as the ImportKey utility is not ALv2 licensed. I wouldn't want the complexities of moving the current test key/cert generation to delay this PR. A script that generates the keys/certs this PR requires would be sufficient. We could either use it as-is or merge it into the existing script. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
