On Wed, Sep 30, 2026 at 1:55 PM <[email protected]> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> markt-asf pushed a commit to branch 9.0.x
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/9.0.x by this push:
> new 08d7017f90 Partial revert of c817143f and a further correction
> 08d7017f90 is described below
>
> commit 08d7017f9057d606483fe17ea794f3c9ee0646fb
> Author: Mark Thomas <[email protected]>
> AuthorDate: Wed Sep 30 12:52:22 2026 +0100
>
> Partial revert of c817143f and a further correction
>
> opencode is hallucinating. The Jakarta Authentication specification is
> explicit that isMandatory is stored as a string value.
>
> Additionally, it should only be stored when it is true.
Sorry for the trouble. The model that did the code review initially
(Qwen 3.8 27B) caused that, usually it does double check but I guess
this failed. Sometimes I catch something I don't want during the
process but I didn't in that case.
Rémy
> ---
> java/org/apache/catalina/authenticator/jaspic/MessageInfoImpl.java | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git
> a/java/org/apache/catalina/authenticator/jaspic/MessageInfoImpl.java
> b/java/org/apache/catalina/authenticator/jaspic/MessageInfoImpl.java
> index 5fda2d9d15..6343cd8310 100644
> --- a/java/org/apache/catalina/authenticator/jaspic/MessageInfoImpl.java
> +++ b/java/org/apache/catalina/authenticator/jaspic/MessageInfoImpl.java
> @@ -59,7 +59,9 @@ public class MessageInfoImpl implements MessageInfo {
> public MessageInfoImpl(HttpServletRequest request, HttpServletResponse
> response, boolean authMandatory) {
> this.request = request;
> this.response = response;
> - map.put(IS_MANDATORY, Boolean.valueOf(authMandatory));
> + if (authMandatory) {
> + map.put(IS_MANDATORY, Boolean.toString(authMandatory));
> + }
> }
>
> @Override
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
