This is an automated email from the ASF dual-hosted git repository.
markt-asf pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new faf0c6d1df Partial revert of 99d1d567
faf0c6d1df is described below
commit faf0c6d1df7548c40481deecc675c6581e7f62b3
Author: Mark Thomas <[email protected]>
AuthorDate: Wed Sep 30 13:28:00 2026 +0100
Partial revert of 99d1d567
"" is a valid URL pattern
---
.../org/apache/catalina/core/ApplicationServletRegistration.java | 2 +-
.../apache/catalina/core/TestApplicationServletRegistration.java | 9 +--------
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/java/org/apache/catalina/core/ApplicationServletRegistration.java
b/java/org/apache/catalina/core/ApplicationServletRegistration.java
index c4448b8f5f..29c3a78454 100644
--- a/java/org/apache/catalina/core/ApplicationServletRegistration.java
+++ b/java/org/apache/catalina/core/ApplicationServletRegistration.java
@@ -177,7 +177,7 @@ public class ApplicationServletRegistration implements
ServletRegistration.Dynam
}
for (String urlPattern : urlPatterns) {
- if (urlPattern == null || urlPattern.isEmpty()) {
+ if (urlPattern == null) {
throw new
IllegalArgumentException(sm.getString("applicationServletRegistration.nullUrlPattern"));
}
}
diff --git
a/test/org/apache/catalina/core/TestApplicationServletRegistration.java
b/test/org/apache/catalina/core/TestApplicationServletRegistration.java
index d8f0391297..f8cf64462c 100644
--- a/test/org/apache/catalina/core/TestApplicationServletRegistration.java
+++ b/test/org/apache/catalina/core/TestApplicationServletRegistration.java
@@ -46,7 +46,7 @@ public class TestApplicationServletRegistration extends
TomcatBaseTest {
@Test
- public void testAddMappingNullAndEmptyPatterns() {
+ public void testAddMappingNullPatterns() {
StandardContext context = new StandardContext();
Wrapper wrapper = context.createWrapper();
@@ -68,13 +68,6 @@ public class TestApplicationServletRegistration extends
TomcatBaseTest {
} catch (IllegalArgumentException e) {
// Expected
}
-
- try {
- registration.addMapping("");
- Assert.fail("Expected an IllegalArgumentException for an empty
pattern");
- } catch (IllegalArgumentException e) {
- // Expected
- }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
