On Tue, Oct 6, 2026 at 2:44 PM <[email protected]> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> markt-asf pushed a commit to branch main
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/main by this push:
> new 9a7ac9b10b Resolve IDE warnings
> 9a7ac9b10b is described below
>
> commit 9a7ac9b10be0fab18854ed28a0af1c8736f2df0d
> Author: Mark Thomas <[email protected]>
> AuthorDate: Tue Oct 6 13:44:25 2026 +0100
>
> Resolve IDE warnings
> ---
> java/org/apache/tomcat/util/http/parser/AcceptLanguage2.java | 1 +
> test/org/apache/catalina/connector/TestRequest.java | 2 +-
> test/org/apache/tomcat/util/http/parser/TestAcceptLanguage.java | 2 +-
> 3 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/java/org/apache/tomcat/util/http/parser/AcceptLanguage2.java
> b/java/org/apache/tomcat/util/http/parser/AcceptLanguage2.java
> index cb7f39d3fd..ccdd554cc6 100644
> --- a/java/org/apache/tomcat/util/http/parser/AcceptLanguage2.java
> +++ b/java/org/apache/tomcat/util/http/parser/AcceptLanguage2.java
> @@ -42,6 +42,7 @@ import java.util.Locale;
> * {@link Locale#ROOT}.</li>
> * </ul>
> */
> +@SuppressWarnings("javadoc")
Some javadoc warnings have been introduced (as usual ;) ) when making
code changes. I'll batch fix them eventually. However, I don't see any
javadoc warnings in this class.
Did I miss anything ?
Sorry for the autoboxing ...
Rémy
> public final class AcceptLanguage2 {
>
> private AcceptLanguage2() {
> diff --git a/test/org/apache/catalina/connector/TestRequest.java
> b/test/org/apache/catalina/connector/TestRequest.java
> index 6898acfd34..54cac1f789 100644
> --- a/test/org/apache/catalina/connector/TestRequest.java
> +++ b/test/org/apache/catalina/connector/TestRequest.java
> @@ -850,7 +850,7 @@ public class TestRequest extends TomcatBaseTest {
> if (i > 0) {
> acceptLanguage.append(',');
> }
> - acceptLanguage.append(String.format("aa-%03d", i));
> + acceptLanguage.append(String.format("aa-%03d",
> Integer.valueOf(i)));
> }
> return acceptLanguage.toString();
> }
> diff --git a/test/org/apache/tomcat/util/http/parser/TestAcceptLanguage.java
> b/test/org/apache/tomcat/util/http/parser/TestAcceptLanguage.java
> index 86dcc093de..766627df3e 100644
> --- a/test/org/apache/tomcat/util/http/parser/TestAcceptLanguage.java
> +++ b/test/org/apache/tomcat/util/http/parser/TestAcceptLanguage.java
> @@ -394,7 +394,7 @@ public class TestAcceptLanguage {
> if (i > 0) {
> header.append(',');
> }
> - header.append("aa-").append(String.format("%03d", i));
> + header.append("aa-").append(String.format("%03d",
> Integer.valueOf(i)));
> }
>
> Assert.assertEquals(100, AcceptLanguage.parse(new
> StringReader(header.toString()), -1).size());
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
