On Mon, Oct 19, 2026 at 8:46 PM Mark Thomas <[email protected]> wrote:
>
> On 19/10/2026 19:40, Mark Thomas wrote:
> > On 08/10/2026 16:42, [email protected] wrote:
> >> This is an automated email from the ASF dual-hosted git repository.
> >>
> >> rmaucher pushed a commit to branch main
> >> in repository https://gitbox.apache.org/repos/asf/tomcat.git
> >>
> >> commit 363ec9f0d3c8a9e8518c05473ababc419efae608
> >> Author: opencode <[email protected]>
> >> AuthorDate: Thu Oct 8 14:46:53 2026 +0200
> >>
> >>      Keep the Last-Modified header for large unbuffered SSI documents
> >>      In the default unbuffered mode, SSIServlet streams the processed
> >> output
> >>      directly to the response writer. Documents larger than the response
> >>      buffer commit the response while processing, so the Last-Modified
> >> header
> >>      that was set after processing completed was silently ignored and
> >> large
> >>      SSI pages were served without it.
> >>      Set the header from the source resource's last modified time
> >> before the
> >>      output is generated, and upgrade it to the value aggregated from the
> >>      directives afterwards only when it is newer and the response has not
> >>      been committed yet. This keeps the previous behavior for buffered
> >>      processing and responses that stay uncommitted.
> >
> > I think this needs to be reverted.
> >
> > For large responses, an incorrect, source based, Last-Modified date will
> > be set which is worse than not setting one at all.
>
> To clarify this having seen two different AIs give very different
> opinions...
>
> I think it needs to be reverted as my understanding is that a stale
> Last-Modified value could confuse a cache.

Yes, ok, I misinterpreted the situation, I should have compared it to
JSP instead of some static file.

Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to