This is an automated email from the ASF dual-hosted git repository.

markt-asf pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
     new 7e4a1615ea Fix failing test. The feature isn't available on APR so 
skip it.
7e4a1615ea is described below

commit 7e4a1615ea84ee9840bd42050629ba0c680ddd4d
Author: Mark Thomas <[email protected]>
AuthorDate: Tue Oct 20 22:45:31 2026 +0100

    Fix failing test. The feature isn't available on APR so skip it.
---
 test/org/apache/tomcat/util/net/TestLargeClientHello.java | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/test/org/apache/tomcat/util/net/TestLargeClientHello.java 
b/test/org/apache/tomcat/util/net/TestLargeClientHello.java
index afe4215611..cb07639563 100644
--- a/test/org/apache/tomcat/util/net/TestLargeClientHello.java
+++ b/test/org/apache/tomcat/util/net/TestLargeClientHello.java
@@ -27,6 +27,7 @@ import javax.net.ssl.SSLContext;
 import javax.net.ssl.TrustManager;
 
 import org.junit.Assert;
+import org.junit.Assume;
 import org.junit.Test;
 
 import org.apache.catalina.Context;
@@ -99,6 +100,10 @@ public class TestLargeClientHello extends TomcatBaseTest {
 
     @Test
     public void testClientHelloLargerThanParseLimit() throws Exception {
+        // sniParseLimit and the SNI fallback are only implemented for the 
JSSE based endpoints (NIO and NIO2)
+        Assume.assumeFalse(
+                
"org.apache.coyote.http11.Http11AprProtocol".equals(System.getProperty("tomcat.test.protocol")));
+
         Tomcat tomcat = getTomcatInstance();
 
         Context ctx = getProgrammaticRootContext();
@@ -132,8 +137,8 @@ public class TestLargeClientHello extends TomcatBaseTest {
             out.write(record);
             out.flush();
 
-            String sniDefault = 
TomcatBaseTest.getKeyFromPropertiesFile("org.apache.tomcat.util.net",
-                    "channel.nio.ssl.sniDefault");
+            String sniDefault =
+                    
TomcatBaseTest.getKeyFromPropertiesFile("org.apache.tomcat.util.net", 
"channel.nio.ssl.sniDefault");
 
             // The fallback to the default SSLHostConfig is logged once the 
extraction returns UNDERFLOW
             long start = System.currentTimeMillis();


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to