arturobernalg commented on PR #1124: URL: https://github.com/apache/tomcat/pull/1124#issuecomment-6435821607
Review feedback addressed: - Fixed `Http2Error.COMPRESSION_ERROR` → `Http2Error.PROTOCOL_ERROR` in `Http2Parser.validateFrame()` for the `headersCurrentStream != streamId` branch (RFC 9113 §6.2: any frame interleaved during a header block on a different stream is a connection error of type PROTOCOL_ERROR). - Updated `TestHttp2Section_6_3`, `TestHttp2Section_4_3` (non-contiguous test), and `TestHttp2Section_5_5` to expect `PROTOCOL_ERROR`. - Added `testContinuationFrameOnWrongStream` and `testRstStreamOnDifferentStreamDuringHeaderBlock` to `TestHttp2Section_6_2`. - Left `TestHttp2Section_4_3#testHeaderDecodingError` unchanged (genuine HPACK `COMPRESSION_ERROR`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
