sainadh777 opened a new pull request, #1126: URL: https://github.com/apache/tomcat/pull/1126
## Summary - document why `FilterDef` retains the supplied `async-supported` string while exposing a normalized runtime boolean - replace the stale annotation-test FIXME with that rationale and assert the normalized value - remove completed TODO 88.1 ## Rationale and impact `FilterDef` intentionally keeps the original descriptor value for merging and serialization. Runtime code uses `getAsyncSupportedBoolean()` instead. Documenting both representations prevents a future cleanup from conflating their roles, and the added assertion covers the annotation-processing path. This is an internal documentation and test-coverage change. It does not alter runtime behavior, so no changelog entry is required. ## Validation All definitive gates ran against commit `748f237c322b0b27a62bef552eda8fee485c9a46` as an unprivileged user in a fresh `eclipse-temurin:21-jdk-jammy` Linux overlayfs container with OpenSSL 3.0.2. - `ant validate` — BUILD SUCCESSFUL - `ant -Dtest.entry=org.apache.catalina.startup.TestContextConfigAnnotation test` — 10 tests, 0 failures, 0 errors, 0 skipped; BUILD SUCCESSFUL - `ant clean deploy` — BUILD SUCCESSFUL - `ant clean test` — 42,579 tests across 781 suites, 0 failures, 0 errors, 363 optional/environment skips; BUILD SUCCESSFUL in 25m45s - generated distribution smoke test: `bin/catalina.sh run`, `curl http://127.0.0.1:8080/`, then `bin/catalina.sh stop 10` — HTTP 200, foreground child exit 0, no remaining Bootstrap process, port 8080 closed, and post-stop HTTP unavailable Diagnostic note: the first smoke wrapper received HTTP 200 and shut Tomcat down, but its post-check falsely matched the wrapper process itself after `catalina.sh run` did not create the requested PID file. The corrected foreground-child smoke command above passed all shutdown checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
