This is an automated email from the ASF dual-hosted git repository.
markt-asf pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 0de54ce710 Add the RedundantModifier check to the test code and fix
issues
0de54ce710 is described below
commit 0de54ce710ff6b22c050ab9f996c927e355532ec
Author: Mark Thomas <[email protected]>
AuthorDate: Wed Oct 28 12:11:54 2026 +0000
Add the RedundantModifier check to the test code and fix issues
---
.../src/test/java/org/apache/tomcat/jdbc/naming/TestNamingFactory.java | 2 +-
.../apache/tomcat/jdbc/pool/interceptor/TestInterceptorResetOrder.java | 2 +-
.../test/java/org/apache/tomcat/jdbc/pool/jmx/TestJmxRegistration.java | 2 +-
res/checkstyle/test-checkstyle.xml | 1 +
4 files changed, 4 insertions(+), 3 deletions(-)
diff --git
a/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/naming/TestNamingFactory.java
b/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/naming/TestNamingFactory.java
index 754c314081..8e61c923a4 100644
---
a/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/naming/TestNamingFactory.java
+++
b/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/naming/TestNamingFactory.java
@@ -350,7 +350,7 @@ class TestNamingFactory extends JdbcPoolBaseTest {
/** Target whose no-argument constructor throws. */
public static class ThrowingCtorTarget {
- public ThrowingCtorTarget() {
+ ThrowingCtorTarget() {
throw new IllegalStateException("boom");
}
}
diff --git
a/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/interceptor/TestInterceptorResetOrder.java
b/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/interceptor/TestInterceptorResetOrder.java
index 74607d920f..5504b716ea 100644
---
a/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/interceptor/TestInterceptorResetOrder.java
+++
b/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/interceptor/TestInterceptorResetOrder.java
@@ -147,7 +147,7 @@ class TestInterceptorResetOrder extends JdbcPoolBaseTest {
static volatile boolean fail;
- public Unconstructable() {
+ Unconstructable() {
if (fail) {
throw new IllegalStateException();
}
diff --git
a/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/jmx/TestJmxRegistration.java
b/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/jmx/TestJmxRegistration.java
index a2245a8846..afb48cb014 100644
---
a/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/jmx/TestJmxRegistration.java
+++
b/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/jmx/TestJmxRegistration.java
@@ -73,7 +73,7 @@ class TestJmxRegistration extends JdbcPoolBaseTest {
public static class Probe implements ProbeMBean {
private final String marker;
- public Probe(String marker) {
+ Probe(String marker) {
this.marker = marker;
}
diff --git a/res/checkstyle/test-checkstyle.xml
b/res/checkstyle/test-checkstyle.xml
index c9884730c3..a1ccab1689 100644
--- a/res/checkstyle/test-checkstyle.xml
+++ b/res/checkstyle/test-checkstyle.xml
@@ -92,6 +92,7 @@
<!-- Modifiers -->
<module name="ModifierOrder"/>
+ <module name="RedundantModifier"/>
<!-- Whitespace -->
<module name="GenericWhitespace"/>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
