arturobernalg opened a new pull request, #1129: URL: https://github.com/apache/tomcat/pull/1129
RFC 9113, section 5.1 states: > An endpoint that receives any frame other than PRIORITY, WINDOW_UPDATE, or RST_STREAM on a closed stream MUST treat this as a connection error (Section 5.4.1) of type STREAM_CLOSED or PROTOCOL_ERROR. The `CLOSED_RST_RX` state (stream closed because a RST_STREAM was received from the peer) had `connectionErrorForInvalidFrame=false`, so any frame not in the permitted set — in particular DATA — triggered a `StreamException` and caused the server to reply with a RST_STREAM instead of closing the connection with GOAWAY. That is a stream error where the RFC mandates a connection error. Fix: set `connectionErrorForInvalidFrame=true` for `CLOSED_RST_RX`, and add RST_STREAM and WINDOW_UPDATE to the permitted set so they are silently accepted as the RFC requires. Update `TestHttp2Section_5_1#testClosedInvalidFrame01` to assert the correct connection-error (GOAWAY STREAM_CLOSED) response. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
