This is an automated email from the ASF dual-hosted git repository. rmaucher pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit f427d7ac0e806889865ac39cee038f3c31d30e5e Author: opencode <[email protected]> AuthorDate: Tue Nov 3 00:35:05 2026 +0100 Meet the checkstyle rules in the pool's test sources Two errors stopped "ant validate" from passing, both in test sources the recent work touched. TestPoolProperties listed its org.apache import ahead of the org.junit ones. The configured groups are java, javax, jakarta, org.hamcrest, org.junit, org - each separated - so the org.junit pair now leads and the pool import follows behind its own separator, the way the other tests in the module read. TestSuspectReportedOnce imported javax.management.Notification without naming the type: the notification arrives as the inferred parameter of a NotificationListener lambda, so the import was only ever a compile-time decoration. --- .../src/test/java/org/apache/tomcat/jdbc/pool/TestPoolProperties.java | 3 ++- .../test/java/org/apache/tomcat/jdbc/pool/TestSuspectReportedOnce.java | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/TestPoolProperties.java b/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/TestPoolProperties.java index 0a92160c05..52dd0c3365 100644 --- a/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/TestPoolProperties.java +++ b/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/TestPoolProperties.java @@ -20,10 +20,11 @@ import java.util.ArrayList; import java.util.List; import java.util.Properties; -import org.apache.tomcat.jdbc.pool.util.MessageFactory; import org.junit.jupiter.api.Assertions; import org.junit.jupiter.api.Test; +import org.apache.tomcat.jdbc.pool.util.MessageFactory; + /** * Configuration only, no database and no pool: {@code PoolProperties} * renders itself for logging and diagnostics. The rendering must not leak diff --git a/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/TestSuspectReportedOnce.java b/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/TestSuspectReportedOnce.java index fe3dd2e90e..714227cc27 100644 --- a/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/TestSuspectReportedOnce.java +++ b/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/TestSuspectReportedOnce.java @@ -21,7 +21,6 @@ import java.util.concurrent.TimeUnit; import java.util.concurrent.atomic.AtomicBoolean; import java.util.concurrent.atomic.AtomicInteger; -import javax.management.Notification; import javax.management.NotificationListener; import org.junit.jupiter.api.Assertions; --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
