arturobernalg opened a new pull request, #1145: URL: https://github.com/apache/tomcat/pull/1145
When a sendfile transfer does not complete inline, the Poller registers the connection for OP_READ without resetting the read timeout. The connection then waits for the next request using `connectionTimeout` instead of `keepAliveTimeout`. The inline path already sets the keep-alive timeout in `Http11Processor.dispatchEndRequest()`. The Poller now sets the keep-alive timeout before registering for OP_READ. `TestSendFile.testKeepAliveTimeoutAfterAsyncSendfile` uses `connectionTimeout=2000` and `keepAliveTimeout=30000`, sends a 32 MB file that cannot complete inline and checks the idle connection is still open after the connection timeout. It fails without the change (the server closes the connection) and passes with it. `TestKeepAliveCount`, `TestMaxConnections`, `TestNonBlockingAPI` and `TestHttp2ConnectionTimeouts` still pass. Bugzilla: https://bz.apache.org/bugzilla/show_bug.cgi?id=70287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
