This is an automated email from the ASF dual-hosted git repository. rmaucher pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 023cdabc581d9cdba3171e74f96bcef2b09330c2 Author: opencode <[email protected]> AuthorDate: Fri Nov 6 11:35:34 2026 +0100 Fix checkstyle issues in jdbc-pool tests Remove redundant constructor modifiers, correct the JLS modifier order, and drop an unused import reported by ant validate. --- .../org/apache/tomcat/jdbc/pool/TestPoolInitializationCleanup.java | 2 +- .../org/apache/tomcat/jdbc/pool/TestPooledConnectionHandleLeak.java | 6 +++--- .../pool/interceptor/TestStatementCacheStaleEntryResurrection.java | 1 - 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/TestPoolInitializationCleanup.java b/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/TestPoolInitializationCleanup.java index 524ff0eb5c..6e9b98e6c6 100644 --- a/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/TestPoolInitializationCleanup.java +++ b/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/TestPoolInitializationCleanup.java @@ -90,7 +90,7 @@ class TestPoolInitializationCleanup extends JdbcPoolBaseTest { */ public static class CleanerFailingPool extends ConnectionPool { - public CleanerFailingPool(PoolConfiguration properties) throws SQLException { + CleanerFailingPool(PoolConfiguration properties) throws SQLException { super(properties); } diff --git a/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/TestPooledConnectionHandleLeak.java b/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/TestPooledConnectionHandleLeak.java index 0aed81e01e..fc96cbfb28 100644 --- a/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/TestPooledConnectionHandleLeak.java +++ b/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/TestPooledConnectionHandleLeak.java @@ -40,7 +40,7 @@ import org.apache.tomcat.jdbc.JdbcPoolBaseTest; */ class TestPooledConnectionHandleLeak extends JdbcPoolBaseTest { - private static abstract class FailingHandle { + private abstract static class FailingHandle { int closeAttempts; boolean closed; @@ -100,7 +100,7 @@ class TestPooledConnectionHandleLeak extends JdbcPoolBaseTest { private final XAConnection connection; - public FailingXaDataSource(XAConnection connection) { + FailingXaDataSource(XAConnection connection) { this.connection = connection; } @@ -177,7 +177,7 @@ class TestPooledConnectionHandleLeak extends JdbcPoolBaseTest { private final javax.sql.PooledConnection connection; - public FailingConnectionPoolDataSource(javax.sql.PooledConnection connection) { + FailingConnectionPoolDataSource(javax.sql.PooledConnection connection) { this.connection = connection; } diff --git a/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/interceptor/TestStatementCacheStaleEntryResurrection.java b/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/interceptor/TestStatementCacheStaleEntryResurrection.java index a5d95820df..297c79b6df 100644 --- a/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/interceptor/TestStatementCacheStaleEntryResurrection.java +++ b/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/interceptor/TestStatementCacheStaleEntryResurrection.java @@ -26,7 +26,6 @@ import org.junit.jupiter.api.Test; import org.apache.tomcat.jdbc.JdbcPoolBaseTest; import org.apache.tomcat.jdbc.pool.DataSource; -import org.apache.tomcat.jdbc.pool.PooledConnection; /** * A cached statement belongs to the physical session it was prepared on, so --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
