arturobernalg opened a new pull request, #1162: URL: https://github.com/apache/tomcat/pull/1162
RFC 9113 section 3.4 requires the client connection preface to include a SETTINGS frame and says an invalid connection preface is a connection error of type PROTOCOL_ERROR. With async I/O, if the first frame after the preface was not SETTINGS, Http2AsyncParser reported it as a stream error, swallowed the payload and carried on. For a PING the server then sent a RST_STREAM frame for stream 0, which section 6.4 does not allow, and the connection stayed open so later requests were served. Any error in the first frame is now handled as a connection error. The new test fails without the change when async I/O is used (the test client rejects the RST_STREAM on stream 0) and passes with it. It also fails and passes the same way on 11.0.x and 10.1.x. The whole coyote/http2 test package passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
