arturobernalg opened a new pull request, #1249: URL: https://github.com/apache/tomcat/pull/1249
RFC 9110, section 5.1 requires a field name to be a token. An application that sets a header such as "bad name" or "X:Y" currently has the field sent as is, over HTTP/1.1 and over HTTP/2, where a strict client treats the response as malformed. This ignores such fields in Response.setHeader() and Response.addHeader() so that the behaviour is the same for every protocol. It complements #1154, which removes them at the HTTP/2 encoder. Checked against a running Tomcat: before the change the response contained "bad name: v"; with it the field is gone for HTTP/1.1 and HTTP/2, while valid fields (including repeated ones and Set-Cookie) are unchanged. The tests for the connector, core, filters, servlets, valves and coyote packages pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
