arturobernalg opened a new pull request, #1263:
URL: https://github.com/apache/tomcat/pull/1263

   RFC 9110, section 10.1.1 says "The Expect field value is case-insensitive." 
HTTP/1.1 already compares `100-continue` ignoring case 
(`Http11Processor.prepareExpectation`), but HTTP/2 used `equals()` in 
`Stream.emitHeader`. A request with `Expect: 100-Continue` over HTTP/2 
therefore never got a 100 (Continue) response and the client waited for its own 
timeout before sending the request content.
   
   With curl over h2c and an 8 second expect timeout, a 200 KB POST took about 
8 s with `100-Continue` and a few milliseconds with `100-continue`. With the 
change, both take a few milliseconds. httpd 2.4.69 (mod_http2) and Netty 
(`HttpUtil.is100ContinueExpected`) accept any case.
   
   testSendAckMixedCase in TestHttp2Section_8_1 fails without the change; 
testSendAck checks that the lower case value still gets the 100 (Continue) 
response.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to