arturobernalg commented on PR #980:
URL: https://github.com/apache/tomcat/pull/980#issuecomment-7059057262

   This needs a rebase: it conflicts with main in TestErrorReportValve and 
doesn't compile, because addServletMappingDecoded() was removed (65bb847e56).
    
     After fixing that, 
TestLoadBalancerDrainingValveUnit.testSessionURIParamStripped fails. Since 
16d9dbd3a9 the valve calls getRequestedSessionId(), which the strict mock 
doesn't expect. Adding 
     expect(request.getRequestedSessionId()).andStubReturn(null) fixes it.
   
     A few other things:
     - testThresholdDisabled and testIsAllowedNoPortWhenExpected still pass 
with the logic they test removed.
     - Several TestRemoteCIDRValve tests duplicate TestRequestFilterValve.
     - testInvalidAllow/testInvalidDeny go through a DNS lookup (~4 s); an 
out-of-range prefix such as 192.168.0.0/33 avoids that.
     - The new StuckThread tests add ~13 s; asserting 
getStuckThreadNames()/getInterruptedThreadsCount() in the existing 
testDetection/testInterruption would cost nothing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to