Author: fhanik Date: Mon Nov 12 07:53:22 2007 New Revision: 594192 URL: http://svn.apache.org/viewvc?rev=594192&view=rev Log: proposing a third fix, still need to validate the value for escaping
Modified: tomcat/tc6.0.x/trunk/STATUS Modified: tomcat/tc6.0.x/trunk/STATUS URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?rev=594192&r1=594191&r2=594192&view=diff ============================================================================== --- tomcat/tc6.0.x/trunk/STATUS (original) +++ tomcat/tc6.0.x/trunk/STATUS Mon Nov 12 07:53:22 2007 @@ -51,15 +51,20 @@ and $Version parsing +1: jfclere, pero -1: markt - only the double quoting part - see http://marc.info/?l=tomcat-dev&m=119454915422424&w=2 for reasons - -1: fhanik - proposed patch http://people.apache.org/~fhanik/patches/cookies-fix.patch - -* Alternate Cookies fix - http://people.apache.org/~fhanik/patches/cookies-fix-2.patch - Includes: Version fix, Escape fix - Excludes: Already quoted fix, vetoed in prev proposal - +1: fhanik - -1: jfclere TC doesn't pass TCK tests with your patch. +1 for the version part. + -1: fhanik - proposed patch below * Fix licensing of JSP 2.1 schema svn diff -c r593814 +1: markt, remm, jfclere -1: + +* Fix cookie parsing, rev 3 + Includes: Version fix, Escape fix, already quoted fix + It seems that the TCK doesn't do a good job at knowing what an escape character is. + Since the TCK does set an "already quoted" value, we should assume that that is how they interpret the cookie handling in the servlet spec + In this fix however, alreadyQuoted also checks for escaped values, and ignores them + http://people.apache.org/~fhanik/patches/cookies-fix-3.patch + +1: fhanik + -1: + + \ No newline at end of file --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]