https://issues.apache.org/bugzilla/show_bug.cgi?id=38483
--- Comment #9 from Peter Rossbach <[EMAIL PROTECTED]> 2008-04-04 05:26:40 PST
---
The question is also: How we can fix it:
Critical section at AccessLogValve is (LL 581 (current tomcat 5.5 trunk):
result.append("[");
result.append(dayFormatter.format(date)); // Day
result.append('/');
result.append(lookup(monthFormatter.format(date))); // Month
result.append('/');
result.append(yearFormatter.format(date)); // Year
result.append(':');
result.append(timeFormatter.format(date)); // Time
result.append(space);
result.append(getTimeZone(date)); // Time Zone
result.append("] \"");
Not only the timeFormatter is the problem :-(
Option to fix:
a) synchronize the complete formatter access
easy to implement, but can be a performance problem
b) use a cache with some threadLocals
can be a memory leak at shrinking request thread pools
c) use some formatter object pools
little implementation overhead and we must also use a sync datastructure!
Peter
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
