Author: markt
Date: Thu May 15 10:54:42 2008
New Revision: 656762
URL: http://svn.apache.org/viewvc?rev=656762&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43333
Correct sendfile docs
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/webapps/docs/aio.xml
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=656762&r1=656761&r2=656762&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu May 15 10:54:42 2008
@@ -51,12 +51,6 @@
+1: jfclere, rjung, fhanik, remm, pero
-1:
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43333
- Correct sendfile docs
- http://svn.apache.org/viewvc?rev=652666&view=rev
- +1: markt, remm, pero
- -1:
-
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43150
Start if the installation path contains #
http://svn.apache.org/viewvc?rev=652669&view=rev
Modified: tomcat/tc6.0.x/trunk/webapps/docs/aio.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/aio.xml?rev=656762&r1=656761&r2=656762&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/webapps/docs/aio.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/aio.xml Thu May 15 10:54:42 2008
@@ -327,10 +327,11 @@
<p>
Any servlet can instruct Tomcat to perform a sendfile call by setting the
appropriate
- response attributes. When using sendfile, it is best to ensure that
neither the
+ request attributes. It is also necessary to correctly set the content
length
+ for the response. When using sendfile, it is best to ensure that neither
the
request or response have been wrapped, since as the response body will be
sent later
by the connector itself, it cannot be filtered. Other than setting the 3
needed
- response attributes, the servlet should not send any response data, but it
may use
+ request attributes, the servlet should not send any response data, but it
may use
any method which will result in modifying the response header (like
setting cookies).
</p>
@@ -338,7 +339,7 @@
<li>org.apache.tomcat.sendfile.filename: Canonical filename of the file
which will be sent as
a String</li>
<li>org.apache.tomcat.sendfile.start: Start offset as a Long</li>
- <li>org.apache.tomcat.sendfile.start: End offset as a Long</li>
+ <li>org.apache.tomcat.sendfile.end: End offset as a Long</li>
</ul>
</section>
Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=656762&r1=656761&r2=656762&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Thu May 15 10:54:42 2008
@@ -231,6 +231,9 @@
updated commons-pool and commons-DBCP. (markt)
</fix>
<fix>
+ <bug>43333</bug>: Fix errors in sendfile documentation. (markt)
+ </fix>
+ <fix>
<bug>43366</bug>: Provide backwards compatibility for manager sessions
command. (markt)
</fix>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
