On Wed, 2008-05-21 at 00:16 +0100, Mark Thomas wrote: > [EMAIL PROTECTED] wrote: > > * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42747 > > Use any META-INF/context.xml in a consistent manner and ensure it is > > used on > > @@ -95,4 +92,6 @@ > > -1: remm (would need convincing that this is really well tested, > > otherwise delay to next release) > > markt Exactly what would convince you that this was well tested > > above and > > beyond the local testing that I have done to convince myself > > that > > - this patch does what I want it to. > > \ No newline at end of file > > + this patch does what I want it to. > > + remm I am not sure this was fully tested. For example, the order of > > redeployResources is > > + likely significant, and it is changed in deployDirectory > > \ No newline at end of file > > You'd think the order mattered since someone went to the bother of > specifying a LinkedHashMap but I didn't see anything in checkResources() - > the only place the data is read - that depended on order. Do you see > something I don't?
That someone who used a LinkedHashMap was me, and the order should be significant (after checking, some operations are done on the rest of the list, like: for (int j = i + 1; j < resources.length; j++)). Rémy --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
