Author: rjung
Date: Mon Aug 25 13:08:05 2008
New Revision: 688857

URL: http://svn.apache.org/viewvc?rev=688857&view=rev
Log:
Remove recycle of B2CConverter when used for URI conversion.

Recycle was an empty method until recently. It now eats up
all bytes in the ByteChunk underlying the B2CConverter in
order to fix BZ44494. That's fine and necessary for the
B2CConverter use in InputBuffer at the end of request handling,
but here, in the case of URI conversion, the associated
ByteChunk comes from a convert call of a previous request
and we will destroy a ByteChunk we still need to use outside of the
B2CConverter.

Modified:
    tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java?rev=688857&r1=688856&r2=688857&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Mon Aug 
25 13:08:05 2008
@@ -620,8 +620,6 @@
                 if (conv == null) {
                     conv = new B2CConverter(enc);
                     request.setURIConverter(conv);
-                } else {
-                    conv.recycle();
                 }
             } catch (IOException e) {
                 // Ignore



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to