Author: markt
Date: Sat Feb 21 19:13:54 2009
New Revision: 746568
URL: http://svn.apache.org/viewvc?rev=746568&view=rev
Log:
Respond to Bill's comment
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=746568&r1=746567&r2=746568&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sat Feb 21 19:13:54 2009
@@ -146,6 +146,15 @@
set the timeout correctly outside the loop, and retain the
disableUploadTimeout check.
The first request shouldn't care, since we should already
have available() > 0 with the
JIO connector.
+ markt I took a look at this. I think you do have to set timeouts
+ inside the loop otherwise the request line read doesn't
timeout
+ correctly. I wrote this patch that only sets timeouts when
+ required:
+
http://people.apache.org/~markt/patches/2009-02-12-soTimeout.patch
+ but I'm not sure it is necessary. Is setSoTimeout really that
+ expensive? It takes less than a microsecond on my box. The
code
+ would be cleaner if we just took out most of the tests and set
+ the timeout, even if it was already set as required.
-1:
* Use ThreadLocal rather than syncs for DateFormat to prevent potential
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
