Author: rjung
Date: Tue Mar 17 15:52:08 2009
New Revision: 755289

URL: http://svn.apache.org/viewvc?rev=755289&view=rev
Log:
Vote and comment.

Modified:
    tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=755289&r1=755288&r2=755289&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Tue Mar 17 15:52:08 2009
@@ -47,7 +47,7 @@
   Improved fix that hopefully addresses previous concerns
   
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java?r1=685981&r2=687645&diff_format=h
   
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties?r1=656035&r2=687503
-  +1: markt
+  +1: markt, rjung
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45666
@@ -114,36 +114,36 @@
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45933
   Don't use xml parser from web-app to process tld files
   http://svn.apache.org/viewvc?rev=701355&view=rev
-  +1: markt
+  +1: markt, rjung
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42419
   Support changing of JSESSIONID cookie name and jsessionid path parameter name
   http://svn.apache.org/viewvc?rev=702219&view=rev
-  +1: markt, mturk
+  +1: markt, mturk, rjung
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45996
   Add Accept-Range header to DefaultServlet response
   http://svn.apache.org/viewvc?rev=696408&view=rev
-  +1: mark
+  +1: mark, rjung
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46105
   Correctly set URI encoding when replaying a request after FORM auth
   http://svn.apache.org/viewvc?rev=709294&view=rev
-  +1: markt
+  +1: markt, rjung
   -1: 
 
 * Fix thread safety issues in date formats
   http://svn.apache.org/viewvc?view=rev&revision=708160
-  +1: markt
+  +1: markt, rjung
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46408
   Correct potential invalid cast
   http://svn.apache.org/viewvc?rev=728032&view=rev
-  +1: markt
+  +1: markt, rjung
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=36923
@@ -156,22 +156,22 @@
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37498
   Handle logging errors during undeployment triggered by deleting the base
-  diretcory
+  directory
   https://issues.apache.org/bugzilla/attachment.cgi?id=23069
-  +1: markt
+  +1: markt, rjung
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37458
   Correct sync issue that leads to NPE in rare circumstances
   Patch provided by Konstantin Kolinko
   http://svn.apache.org/viewvc?rev=730735&view=rev
-  +1: markt
+  +1: markt, rjung
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37515
   Add options for 1.6 and 1.7 source and target to JDT compiler
   http://svn.apache.org/viewvc?rev=731773&view=rev
-  +1: markt
+  +1: markt, rjung
   -1: 
 
 * Lock contention during cookie creation, implementation is single threaded
@@ -179,54 +179,63 @@
   This patch realizes that DateFormat is not thread safe, but uses them 
without the need for synchronization using thread locals
   +1: fhanik
   -1: 
+  rjung: http://svn.apache.org/viewvc?rev=709294&view=rev above seems
+  to already fix all cases, in which the problematic DateTool code was
+  actually used in TC 5.5.x.
+  rjung: How does a static thread local work (lifecycle)?
+  Is it lazily initialized for each thread when it starts using the class?
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46606
   Make max depth configurable for WebDAV servlet
   http://svn.apache.org/viewvc?rev=740635&view=rev
-  +1: markt
+  +1: markt, rjung
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38197
   Take account of jsp:attribute elements when naming tag pools
   http://svn.apache.org/viewvc?rev=740675&view=rev
-  +1: markt
+  +1: markt, rjung
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38483
   Make access log valves thread safe
   http://people.apache.org/~markt/patches/2009-02-04-bug38483.patch
-  +1: markt
+  +1: markt, rjung
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38553
   Return 401 rather than 400 if client presents no certs for CLIENT-CERT auth
   http://svn.apache.org/viewvc?rev=740684&view=rev
-  +1: markt
+  +1: markt, rjung
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38570
   When checking docBase against appBase, make sure we check for an exact match
   against the appBase
   http://svn.apache.org/viewvc?rev=742677&view=rev
-  +1: markt
+  +1: markt, rjung
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39013
   When testing for invalid docBase, test for an exact match with the appBase
   dir
   http://svn.apache.org/viewvc?rev=742697&view=rev
-  +1: markt, mturk
+  +1: markt, mturk, rjung
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39396
   Don't include TRACE in OPTIONS response unless we know it hasn't been
   disabled in the connector
   http://svn.apache.org/viewvc?rev=742714&view=rev
-  +1: markt, mturk
+  +1: markt, mturk, rjung
   -1: 
+  rjung: The patch contains a typo, it has two times "POST" instead of "POST"
+  plus "DELETE". I didn't check the trunk/6.0 patches for this typo.
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46717
   Hard to reproduce thread safety issue with session expiration
   http://svn.apache.org/viewvc?rev=708273&view=rev
-  +1: markt
+  +1: markt, rung
   -1: 
+  rjung: I suggest doing the same changes for
+  
container/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaSession.java



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to