Author: markt
Date: Fri Jun 12 22:47:20 2009
New Revision: 784302

URL: http://svn.apache.org/viewvc?rev=784302&view=rev
Log:
Remove commons-collections from the build. It is unused.

Modified:
    tomcat/tc6.0.x/trunk/   (props changed)
    tomcat/tc6.0.x/trunk/STATUS.txt
    tomcat/tc6.0.x/trunk/build.properties.default
    tomcat/tc6.0.x/trunk/build.xml
    tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Jun 12 22:47:20 2009
@@ -1 +1 @@
-/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,673796,673820,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,753039,757335,757774,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,770809,770876,776921,776924,776935,776945,777464,77
 7466,777576,777625,778379,781528,781779,782145,782791,783316
+/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,673796,673820,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,753039,757335,757774,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,770809,770876,776921,776924,776935,776945,777464,77
 7466,777576,777625,778379,781528,781779,782145,782791,783316,783696

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=784302&r1=784301&r2=784302&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jun 12 22:47:20 2009
@@ -121,13 +121,6 @@
   +1: fhanik
   -1: 
 
-* Remove commons-collections from the build. It is unused.
-  http://svn.apache.org/viewvc?rev=783696&view=rev
-  +1: markt, fhanik, kkolinko
-  -1:
-  kkolinko: A comment in build.xml mentions "${commons-collections.home}".
-  You may remove that one too.
-
 * Update commons-pool to 1.5.
   http://svn.apache.org/viewvc?rev=783697&view=rev
   +1: markt, fhanik, kkolinko

Modified: tomcat/tc6.0.x/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/build.properties.default?rev=784302&r1=784301&r2=784302&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/build.properties.default (original)
+++ tomcat/tc6.0.x/trunk/build.properties.default Fri Jun 12 22:47:20 2009
@@ -77,13 +77,6 @@
 commons-pool.home=${base.path}/commons-pool-1.4-src
 
commons-pool-src.loc=${base-commons.loc}/pool/source/commons-pool-1.4-src.tar.gz
 
-# ----- Commons Collections, version 2.0 or later -----
-commons-collections.home=${base.path}/commons-collections-3.2-src
-commons-collections.lib=${commons-collections.home}
-commons-collections.jar=${commons-collections.lib}/commons-collections-3.2.jar
-commons-collections.loc=${base-jakarta.loc}/commons/collections/binaries/commons-collections-3.2.tar.gz
-commons-collections-src.loc=${base-commons.loc}/collections/source/commons-collections-3.2-src.tar.gz
-
 # ----- NSIS, version 2.0 or later -----
 nsis.home=${base.path}/nsis-2.44
 nsis.exe=${nsis.home}/makensis.exe

Modified: tomcat/tc6.0.x/trunk/build.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/build.xml?rev=784302&r1=784301&r2=784302&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/build.xml (original)
+++ tomcat/tc6.0.x/trunk/build.xml Fri Jun 12 22:47:20 2009
@@ -669,10 +669,6 @@
 
     <!-- Build Tomcat DBCP bundle -->
     <antcall target="downloadgz">
-      <param name="sourcefile" value="${commons-collections-src.loc}"/>
-      <param name="destfile" value="${tomcat-dbcp.jar}" />
-    </antcall>
-    <antcall target="downloadgz">
       <param name="sourcefile" value="${commons-pool-src.loc}"/>
       <param name="destfile" value="${tomcat-dbcp.jar}" />
     </antcall>
@@ -706,14 +702,6 @@
 
   <target name="build-tomcat-dbcp" unless="jdk16.present">
     <copy todir="${tomcat-dbcp.home}">
-    <!--
-      <fileset dir="${commons-collections.home}" >
-        <include name="**/collections/CursorableLinkedList.java" />
-        <include name="**/collections/KeyValue.java" />
-        <include name="**/collections/LRUMap.java" />
-        <include name="**/collections/SequencedHashMap.java" />
-      </fileset>
-      -->
       <fileset dir="${commons-pool.home}">
         <include name="**/*.java" />
         <exclude name="**/test/**" />
@@ -723,14 +711,6 @@
         <exclude name="**/test/**" />
       </fileset>
     </copy>
-    <!--
-    <replace dir="${tomcat-dbcp.home}/src/java/org/apache/commons">
-      <replacefilter token="return UnmodifiableList.decorate(l);"
-            value="return l;" />
-      <replacefilter token="import 
org.apache.commons.collections.list.UnmodifiableList;"
-            value=" " />
-    </replace>
-    -->
     <replace dir="${tomcat-dbcp.home}/src/java/org/apache/commons" >
       <replacefilter token="org.apache.commons"
             value="org.apache.tomcat.dbcp" />

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=784302&r1=784301&r2=784302&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Fri Jun 12 22:47:20 2009
@@ -135,6 +135,10 @@
         Use explicit encoding during filtering operations when building Tomcat
         for distribution. (kkolinko)
       </fix>
+      <update>
+        Remove references to unused commons-collections from the build scripts.
+        (markt)
+      </update>
     </changelog>
   </subsection>
 </section>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to