Author: rjung
Date: Tue Jun 30 15:21:26 2009
New Revision: 789792
URL: http://svn.apache.org/viewvc?rev=789792&view=rev
Log:
Vote, comment, update proposal.
Modified:
tomcat/current/tc5.5.x/STATUS.txt
Modified: tomcat/current/tc5.5.x/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=789792&r1=789791&r2=789792&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Tue Jun 30 15:21:26 2009
@@ -39,18 +39,18 @@
http://svn.apache.org/viewvc?rev=656751&view=rev (case A fix)
http://svn.apache.org/viewvc?rev=778523&view=rev (prerequisite)
http://svn.apache.org/viewvc?rev=778524&view=rev (case B fix)
- +1: markt, fhanik
+ +1: markt, fhanik, rjung
+1: kkolinko (with additional patches that are proposed below)
-1:
* Additional patches:
http://svn.apache.org/viewvc?rev=784453&view=rev
http://svn.apache.org/viewvc?rev=784602&view=rev
- +1: kkolinko, markt
+ +1: kkolinko, markt, rjung
-1:
* Make 64-bit binaries/installer available for 5.5.x as well as 6.0.x
http://svn.apache.org/viewvc?rev=777624&view=rev
- +1: markt, fhanik
+ +1: markt, fhanik, rjung
+1: kkolinko (good,
but it won't work without rev=783934 patch that I am proposing below,
because some files were deleted in
@@ -62,7 +62,7 @@
Discussion: http://markmail.org/message/nhkrskh6bwyirwru
It is amendment to the rev=777624 patch proposed above.
http://svn.apache.org/viewvc?rev=783934&view=rev
- +1: kkolinko, markt
+ +1: kkolinko, markt, rjung
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37084
@@ -78,11 +78,19 @@
http://svn.apache.org/viewvc?rev=786487&view=rev
+1: markt
-1:
+ rjung: +1 in principle, but a few questions/suggestions:
+ - Do we need to dechunk the read request body? I didn't see were this
happens.
+ - Do chunked requests actually set a content-length? If not, we have len
== -1
+ and will not enter the try/catch block. Maybe only a question of
correct backport
+ from trunk.
+ - I think instead of: len == actualLen => non-chunked, else check
transfer-encoding
+ it should be the other waqy round. If transfer-encoding is chunked,
handle as chunked,
+ else traditional.
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38352
JSPs should have read/write access to the context's temp dir
http://svn.apache.org/viewvc?rev=786490&view=rev
- +1: markt
+ +1: markt, rjung
-1:
* Update to Apache Commons Pool 1.5.1
@@ -90,7 +98,7 @@
occur fair - ie objects are allocated to threads in the order that the
threads
request them. Fixes a number of issues in DBCP.
http://svn.apache.org/viewvc?rev=786496&view=rev
- +1: markt, kkolinko
+ +1: markt, kkolinko, rjung
-1:
kkolinko: (
Note: The 'Fix download task check' patch (rev.787999) that I propose
below
@@ -101,33 +109,28 @@
* Fix Java 5 dependency Boolean.parseBoolean() (regression)
Introduced in fix for
https://issues.apache.org/bugzilla/show_bug.cgi?id=45996
http://svn.apache.org/viewvc?rev=781546&view=rev
- Patch:
http://people.apache.org/~rjung/patches/2009-06-24-bug45996-regression.patch
- +1: rjung, markt
- +1: kkolinko (
- good, can go on with it
- though it is inconsistent with the code for other boolean options in
the same class.
- I think that
- Boolean.valueOf(str).booleanValue()
- should work in 1.4.
- )
+ Patch:
http://people.apache.org/~rjung/patches/2009-06-30-bug45996-regression.patch
+ updated from a previous proposal based on the comments of Konstantin.
+ mark and konstatin: please vote again.
+ +1: rjung
-1:
* Fix build paths for embed target in build/build.xml
http://people.apache.org/~kkolinko/patches/2009-06-24_tc55_build-paths-embed.patch
- +1: kkolinko, markt
+ +1: kkolinko, markt, rjung
-1:
* Fix download task check for commons-pool and commons-dbcp.
Backport of http://svn.apache.org/viewvc?rev=787999&view=rev
TC 5.5 specific patch is:
http://people.apache.org/~kkolinko/patches/2009-06-24_tc55_rev787999backport.patch
- +1: kkolinko, markt
+ +1: kkolinko, markt, rjung
-1:
* Use different (not the same) values for ${tomcat-dbcp.home} and
${jasper-compiler-jdt.home}.
In TC 6.0 they are already different, but were not in 5.5.
http://people.apache.org/~kkolinko/patches/2009-06-24_tc55_deps-home.patch
- +1: kkolinko, markt
+ +1: kkolinko, markt, rjung
-1:
* Make access log valves thread safe
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
