Cool refactoring!
+1
Peter
Am 13.08.2009 um 22:07 schrieb Filip Hanik - Dev Lists:
Here is why I think its good
1. Current pools can't shrink, so when peak has been hit, that's
where were at
2. Current pools are unfair, synchronized (workers)
{ workers.wait() }, executors are a bit more fair since they only
hold a lock for a short period
3. Reduce duplicate code
4. Executors provide more flexibility
5. I have not found a performance difference anymore
6. Async implementation becomes much easier, since
AsyncContext.dispatch() is easily handed off to an executor and
releasing application thread. Otherwise we have to add an executor
on top of the existing thread pool, which is doable, just not
pragmatic
best
Filip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org