Author: markt Date: Mon Aug 17 22:20:29 2009 New Revision: 805182 URL: http://svn.apache.org/viewvc?rev=805182&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44041 Remove previous sync that didn't fix the issue Make loadClass synchronized like java.lang.ClassLoader I was concerned about possible performance implications but I saw no detectable change in start-up time with this change.
Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java?rev=805182&r1=805181&r2=805182&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java (original) +++ tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java Mon Aug 17 22:20:29 2009 @@ -900,9 +900,7 @@ } if ((clazz == null) && hasExternalRepositories) { try { - synchronized (this) { - clazz = super.findClass(name); - } + clazz = super.findClass(name); } catch(AccessControlException ace) { throw new ClassNotFoundException(name, ace); } catch (RuntimeException e) { @@ -1259,7 +1257,7 @@ * * @exception ClassNotFoundException if the class was not found */ - public Class<?> loadClass(String name, boolean resolve) + public synchronized Class<?> loadClass(String name, boolean resolve) throws ClassNotFoundException { if (log.isDebugEnabled()) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org