https://issues.apache.org/bugzilla/show_bug.cgi?id=48047
Summary: Http11Protocol.Http11ConnectionHandler's
process(Socket socket) method always return false!
Product: Tomcat 6
Version: 6.0.20
Platform: PC
OS/Version: All
Status: NEW
Severity: major
Priority: P2
Component: Connectors
AssignedTo: [email protected]
ReportedBy: [email protected]
Below is the source code of process() method:
public boolean process(Socket socket) {
Http11Processor processor = recycledProcessors.poll();
try {
if (processor == null) {
processor = createProcessor();
}
if (processor instanceof ActionHook) {
((ActionHook) processor).action(ActionCode.ACTION_START,
null);
}
if (proto.secure && (proto.sslImplementation != null)) {
processor.setSSLSupport
(proto.sslImplementation.getSSLSupport(socket));
} else {
processor.setSSLSupport(null);
}
processor.process(socket);
return false;
} catch(java.net.SocketException e) {
// SocketExceptions are normal
Http11Protocol.log.debug
(sm.getString
("http11protocol.proto.socketexception.debug"), e);
} catch (java.io.IOException e) {
// IOExceptions are normal
Http11Protocol.log.debug
(sm.getString
("http11protocol.proto.ioexception.debug"), e);
}
// Future developers: if you discover any other
// rare-but-nonfatal exceptions, catch them here, and log as
// above.
catch (Throwable e) {
// any other exception or error is odd. Here we log it
// with "ERROR" level, so it will show up even on
// less-than-verbose logs.
Http11Protocol.log.error
(sm.getString("http11protocol.proto.error"), e);
} finally {
// if(proto.adapter != null) proto.adapter.recycle();
// processor.recycle();
if (processor instanceof ActionHook) {
((ActionHook) processor).action(ActionCode.ACTION_STOP,
null);
}
recycledProcessors.offer(processor);
}
return false;
}
It is easy to find out that the method always return the boolean value of
'false', which is pointless. It seems that it should return 'true' when process
successfully, as such:
try {
... ...
processor.process(socket);
return true;
} catch(...)
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
