Author: markt Date: Mon Nov 9 21:00:22 2009 New Revision: 834229 URL: http://svn.apache.org/viewvc?rev=834229&view=rev Log: StringManagers should be final
Modified: tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java tomcat/trunk/java/org/apache/catalina/connector/Request.java tomcat/trunk/java/org/apache/catalina/connector/RequestFacade.java tomcat/trunk/java/org/apache/catalina/connector/Response.java tomcat/trunk/java/org/apache/catalina/connector/ResponseFacade.java tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java tomcat/trunk/java/org/apache/catalina/core/ApplicationHttpRequest.java tomcat/trunk/java/org/apache/catalina/core/ApplicationHttpResponse.java tomcat/trunk/java/org/apache/catalina/core/ApplicationRequest.java tomcat/trunk/java/org/apache/catalina/core/ApplicationResponse.java tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java tomcat/trunk/java/org/apache/catalina/core/StandardPipeline.java tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java tomcat/trunk/java/org/apache/catalina/ha/session/DeltaRequest.java tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java tomcat/trunk/java/org/apache/catalina/ha/session/SerializablePrincipal.java tomcat/trunk/java/org/apache/catalina/ha/tcp/ReplicationValve.java tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java tomcat/trunk/java/org/apache/catalina/manager/StatusManagerServlet.java tomcat/trunk/java/org/apache/catalina/manager/host/HostManagerServlet.java tomcat/trunk/java/org/apache/catalina/realm/CombinedRealm.java tomcat/trunk/java/org/apache/catalina/realm/JAASMemoryLoginModule.java tomcat/trunk/java/org/apache/catalina/realm/MemoryRealm.java tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java tomcat/trunk/java/org/apache/catalina/realm/UserDatabaseRealm.java tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java tomcat/trunk/java/org/apache/catalina/session/StandardSession.java tomcat/trunk/java/org/apache/catalina/startup/Embedded.java tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioSender.java tomcat/trunk/java/org/apache/catalina/tribes/util/StringManager.java tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java tomcat/trunk/java/org/apache/catalina/util/ExtensionValidator.java tomcat/trunk/java/org/apache/catalina/util/HexUtils.java tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java tomcat/trunk/java/org/apache/catalina/valves/RequestFilterValve.java tomcat/trunk/java/org/apache/catalina/valves/ValveBase.java tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java tomcat/trunk/java/org/apache/coyote/ajp/AjpMessage.java tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java tomcat/trunk/java/org/apache/coyote/http11/AbstractOutputBuffer.java tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java tomcat/trunk/java/org/apache/coyote/http11/InternalAprOutputBuffer.java tomcat/trunk/java/org/apache/naming/ContextBindings.java tomcat/trunk/java/org/apache/naming/StringManager.java tomcat/trunk/java/org/apache/tomcat/util/http/HttpMessages.java tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java tomcat/trunk/java/org/apache/tomcat/util/res/StringManager.java tomcat/trunk/modules/tomcat-lite/test/org/apache/tomcat/lite/HexDump.java Modified: tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java (original) +++ tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java Mon Nov 9 21:00:22 2009 @@ -111,7 +111,7 @@ /** * The string manager for this package. */ - protected final static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java (original) +++ tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java Mon Nov 9 21:00:22 2009 @@ -33,7 +33,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java (original) +++ tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java Mon Nov 9 21:00:22 2009 @@ -48,7 +48,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/connector/Request.java (original) +++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Mon Nov 9 21:00:22 2009 @@ -145,7 +145,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/connector/RequestFacade.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/RequestFacade.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/connector/RequestFacade.java (original) +++ tomcat/trunk/java/org/apache/catalina/connector/RequestFacade.java Mon Nov 9 21:00:22 2009 @@ -235,7 +235,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Response.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/connector/Response.java (original) +++ tomcat/trunk/java/org/apache/catalina/connector/Response.java Mon Nov 9 21:00:22 2009 @@ -93,7 +93,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/connector/ResponseFacade.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/ResponseFacade.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/connector/ResponseFacade.java (original) +++ tomcat/trunk/java/org/apache/catalina/connector/ResponseFacade.java Mon Nov 9 21:00:22 2009 @@ -108,7 +108,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java (original) +++ tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java Mon Nov 9 21:00:22 2009 @@ -58,7 +58,7 @@ public final class ApplicationFilterConfig implements FilterConfig, Serializable { - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); private static org.apache.juli.logging.Log log = Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationHttpRequest.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationHttpRequest.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/core/ApplicationHttpRequest.java (original) +++ tomcat/trunk/java/org/apache/catalina/core/ApplicationHttpRequest.java Mon Nov 9 21:00:22 2009 @@ -79,7 +79,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationHttpResponse.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationHttpResponse.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/core/ApplicationHttpResponse.java (original) +++ tomcat/trunk/java/org/apache/catalina/core/ApplicationHttpResponse.java Mon Nov 9 21:00:22 2009 @@ -99,7 +99,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationRequest.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationRequest.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/core/ApplicationRequest.java (original) +++ tomcat/trunk/java/org/apache/catalina/core/ApplicationRequest.java Mon Nov 9 21:00:22 2009 @@ -93,7 +93,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationResponse.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationResponse.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/core/ApplicationResponse.java (original) +++ tomcat/trunk/java/org/apache/catalina/core/ApplicationResponse.java Mon Nov 9 21:00:22 2009 @@ -89,7 +89,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java (original) +++ tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java Mon Nov 9 21:00:22 2009 @@ -49,7 +49,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java (original) +++ tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java Mon Nov 9 21:00:22 2009 @@ -247,7 +247,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java (original) +++ tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java Mon Nov 9 21:00:22 2009 @@ -142,7 +142,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/core/StandardPipeline.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardPipeline.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/core/StandardPipeline.java (original) +++ tomcat/trunk/java/org/apache/catalina/core/StandardPipeline.java Mon Nov 9 21:00:22 2009 @@ -114,7 +114,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java (original) +++ tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java Mon Nov 9 21:00:22 2009 @@ -73,7 +73,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = StringManager.getManager(Constants.Package); + protected static final StringManager sm = StringManager.getManager(Constants.Package); // ----------------------------------------------------- Instance Variables Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaRequest.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/DeltaRequest.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/ha/session/DeltaRequest.java (original) +++ tomcat/trunk/java/org/apache/catalina/ha/session/DeltaRequest.java Mon Nov 9 21:00:22 2009 @@ -46,7 +46,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = StringManager + protected static final StringManager sm = StringManager .getManager(Constants.Package); public static final int TYPE_ATTRIBUTE = 0; Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java (original) +++ tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java Mon Nov 9 21:00:22 2009 @@ -67,7 +67,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = StringManager.getManager(Constants.Package); + protected static final StringManager sm = StringManager.getManager(Constants.Package); // ----------------------------------------------------- Instance Variables Modified: tomcat/trunk/java/org/apache/catalina/ha/session/SerializablePrincipal.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/SerializablePrincipal.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/ha/session/SerializablePrincipal.java (original) +++ tomcat/trunk/java/org/apache/catalina/ha/session/SerializablePrincipal.java Mon Nov 9 21:00:22 2009 @@ -50,7 +50,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); // ----------------------------------------------------------- Constructors Modified: tomcat/trunk/java/org/apache/catalina/ha/tcp/ReplicationValve.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/tcp/ReplicationValve.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/ha/tcp/ReplicationValve.java (original) +++ tomcat/trunk/java/org/apache/catalina/ha/tcp/ReplicationValve.java Mon Nov 9 21:00:22 2009 @@ -78,7 +78,7 @@ /** * The StringManager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); private CatalinaCluster cluster = null ; Modified: tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java (original) +++ tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java Mon Nov 9 21:00:22 2009 @@ -233,7 +233,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/manager/StatusManagerServlet.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/StatusManagerServlet.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/manager/StatusManagerServlet.java (original) +++ tomcat/trunk/java/org/apache/catalina/manager/StatusManagerServlet.java Mon Nov 9 21:00:22 2009 @@ -88,7 +88,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/manager/host/HostManagerServlet.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/host/HostManagerServlet.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/manager/host/HostManagerServlet.java (original) +++ tomcat/trunk/java/org/apache/catalina/manager/host/HostManagerServlet.java Mon Nov 9 21:00:22 2009 @@ -138,7 +138,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/realm/CombinedRealm.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/CombinedRealm.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/realm/CombinedRealm.java (original) +++ tomcat/trunk/java/org/apache/catalina/realm/CombinedRealm.java Mon Nov 9 21:00:22 2009 @@ -46,7 +46,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); /** Modified: tomcat/trunk/java/org/apache/catalina/realm/JAASMemoryLoginModule.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/JAASMemoryLoginModule.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/realm/JAASMemoryLoginModule.java (original) +++ tomcat/trunk/java/org/apache/catalina/realm/JAASMemoryLoginModule.java Mon Nov 9 21:00:22 2009 @@ -118,7 +118,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); /** Modified: tomcat/trunk/java/org/apache/catalina/realm/MemoryRealm.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/MemoryRealm.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/realm/MemoryRealm.java (original) +++ tomcat/trunk/java/org/apache/catalina/realm/MemoryRealm.java Mon Nov 9 21:00:22 2009 @@ -89,7 +89,7 @@ /** * The string manager for this package. */ - private static StringManager sm = + private static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java (original) +++ tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java Mon Nov 9 21:00:22 2009 @@ -137,7 +137,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/realm/UserDatabaseRealm.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/UserDatabaseRealm.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/realm/UserDatabaseRealm.java (original) +++ tomcat/trunk/java/org/apache/catalina/realm/UserDatabaseRealm.java Mon Nov 9 21:00:22 2009 @@ -84,7 +84,7 @@ /** * The string manager for this package. */ - private static StringManager sm = + private static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java (original) +++ tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java Mon Nov 9 21:00:22 2009 @@ -197,7 +197,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java (original) +++ tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java Mon Nov 9 21:00:22 2009 @@ -209,7 +209,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); /** Modified: tomcat/trunk/java/org/apache/catalina/session/StandardSession.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/StandardSession.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/session/StandardSession.java (original) +++ tomcat/trunk/java/org/apache/catalina/session/StandardSession.java Mon Nov 9 21:00:22 2009 @@ -242,7 +242,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/startup/Embedded.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/Embedded.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/startup/Embedded.java (original) +++ tomcat/trunk/java/org/apache/catalina/startup/Embedded.java Mon Nov 9 21:00:22 2009 @@ -183,7 +183,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioSender.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioSender.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioSender.java (original) +++ tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioSender.java Mon Nov 9 21:00:22 2009 @@ -48,7 +48,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = StringManager.getManager(Constants.Package); + protected static final StringManager sm = StringManager.getManager(Constants.Package); // ----------------------------------------------------- Instance Variables Modified: tomcat/trunk/java/org/apache/catalina/tribes/util/StringManager.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/util/StringManager.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/tribes/util/StringManager.java (original) +++ tomcat/trunk/java/org/apache/catalina/tribes/util/StringManager.java Mon Nov 9 21:00:22 2009 @@ -242,7 +242,7 @@ * @param packageName The package name */ - public synchronized static StringManager getManager(String packageName) { + public synchronized static final StringManager getManager(String packageName) { StringManager mgr = managers.get(packageName); if (mgr == null) { Modified: tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java (original) +++ tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java Mon Nov 9 21:00:22 2009 @@ -132,7 +132,7 @@ /** * The string manager for this package. */ - private static StringManager sm = + private static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/util/ExtensionValidator.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/util/ExtensionValidator.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/util/ExtensionValidator.java (original) +++ tomcat/trunk/java/org/apache/catalina/util/ExtensionValidator.java Mon Nov 9 21:00:22 2009 @@ -59,7 +59,7 @@ /** * The string resources for this package. */ - private static StringManager sm = + private static final StringManager sm = StringManager.getManager("org.apache.catalina.util"); private static ArrayList<Extension> containerAvailableExtensions = null; Modified: tomcat/trunk/java/org/apache/catalina/util/HexUtils.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/util/HexUtils.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/util/HexUtils.java (original) +++ tomcat/trunk/java/org/apache/catalina/util/HexUtils.java Mon Nov 9 21:00:22 2009 @@ -57,7 +57,7 @@ /** * The string manager for this package. */ - private static StringManager sm = + private static final StringManager sm = StringManager.getManager("org.apache.catalina.util"); Modified: tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java (original) +++ tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java Mon Nov 9 21:00:22 2009 @@ -69,7 +69,7 @@ /** * The StringManager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java (original) +++ tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java Mon Nov 9 21:00:22 2009 @@ -352,7 +352,7 @@ /** * The StringManager for this package. */ - protected static StringManager sm = StringManager.getManager(Constants.Package); + protected static final StringManager sm = StringManager.getManager(Constants.Package); /** * Convert a given comma delimited list of regular expressions into an array of compiled {...@link Pattern} Modified: tomcat/trunk/java/org/apache/catalina/valves/RequestFilterValve.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/RequestFilterValve.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/valves/RequestFilterValve.java (original) +++ tomcat/trunk/java/org/apache/catalina/valves/RequestFilterValve.java Mon Nov 9 21:00:22 2009 @@ -86,7 +86,7 @@ /** * The StringManager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/catalina/valves/ValveBase.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/ValveBase.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/valves/ValveBase.java (original) +++ tomcat/trunk/java/org/apache/catalina/valves/ValveBase.java Mon Nov 9 21:00:22 2009 @@ -104,7 +104,7 @@ /** * The string manager for this package. */ - protected final static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java (original) +++ tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java Mon Nov 9 21:00:22 2009 @@ -67,7 +67,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java (original) +++ tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java Mon Nov 9 21:00:22 2009 @@ -60,7 +60,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpMessage.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpMessage.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/ajp/AjpMessage.java (original) +++ tomcat/trunk/java/org/apache/coyote/ajp/AjpMessage.java Mon Nov 9 21:00:22 2009 @@ -44,7 +44,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java (original) +++ tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java Mon Nov 9 21:00:22 2009 @@ -67,7 +67,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java (original) +++ tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java Mon Nov 9 21:00:22 2009 @@ -61,7 +61,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java Mon Nov 9 21:00:22 2009 @@ -39,7 +39,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); protected static boolean isSecurityEnabled = Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java Mon Nov 9 21:00:22 2009 @@ -47,7 +47,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractOutputBuffer.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractOutputBuffer.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/http11/AbstractOutputBuffer.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/AbstractOutputBuffer.java Mon Nov 9 21:00:22 2009 @@ -101,7 +101,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); // ------------------------------------------------------------- Properties Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java Mon Nov 9 21:00:22 2009 @@ -75,7 +75,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java Mon Nov 9 21:00:22 2009 @@ -59,7 +59,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); public Http11AprProtocol() { Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java Mon Nov 9 21:00:22 2009 @@ -69,7 +69,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); /** Pass config info Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java Mon Nov 9 21:00:22 2009 @@ -63,7 +63,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java Mon Nov 9 21:00:22 2009 @@ -81,7 +81,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalAprOutputBuffer.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalAprOutputBuffer.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/http11/InternalAprOutputBuffer.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/InternalAprOutputBuffer.java Mon Nov 9 21:00:22 2009 @@ -91,7 +91,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/naming/ContextBindings.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/ContextBindings.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/naming/ContextBindings.java (original) +++ tomcat/trunk/java/org/apache/naming/ContextBindings.java Mon Nov 9 21:00:22 2009 @@ -77,7 +77,7 @@ /** * The string manager for this package. */ - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager(Constants.Package); Modified: tomcat/trunk/java/org/apache/naming/StringManager.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/StringManager.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/naming/StringManager.java (original) +++ tomcat/trunk/java/org/apache/naming/StringManager.java Mon Nov 9 21:00:22 2009 @@ -208,7 +208,7 @@ * @param packageName */ - public synchronized static StringManager getManager(String packageName) { + public synchronized static final StringManager getManager(String packageName) { StringManager mgr = managers.get(packageName); if (mgr == null) { mgr = new StringManager(packageName); Modified: tomcat/trunk/java/org/apache/tomcat/util/http/HttpMessages.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/HttpMessages.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/tomcat/util/http/HttpMessages.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/http/HttpMessages.java Mon Nov 9 21:00:22 2009 @@ -30,7 +30,7 @@ */ public class HttpMessages { // XXX move message resources in this package - protected static StringManager sm = + protected static final StringManager sm = StringManager.getManager("org.apache.tomcat.util.http.res"); static String st_200=null; Modified: tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java Mon Nov 9 21:00:22 2009 @@ -80,7 +80,7 @@ public class JSSESocketFactory extends org.apache.tomcat.util.net.ServerSocketFactory { - private static StringManager sm = + private static final StringManager sm = StringManager.getManager("org.apache.tomcat.util.net.jsse.res"); // defaults Modified: tomcat/trunk/java/org/apache/tomcat/util/res/StringManager.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/res/StringManager.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/tomcat/util/res/StringManager.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/res/StringManager.java Mon Nov 9 21:00:22 2009 @@ -158,7 +158,7 @@ * * @param packageName The package name */ - public synchronized static StringManager getManager(String packageName) { + public synchronized static final StringManager getManager(String packageName) { StringManager mgr = managers.get(packageName); if (mgr == null) { mgr = new StringManager(packageName); Modified: tomcat/trunk/modules/tomcat-lite/test/org/apache/tomcat/lite/HexDump.java URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/tomcat-lite/test/org/apache/tomcat/lite/HexDump.java?rev=834229&r1=834228&r2=834229&view=diff ============================================================================== --- tomcat/trunk/modules/tomcat-lite/test/org/apache/tomcat/lite/HexDump.java (original) +++ tomcat/trunk/modules/tomcat-lite/test/org/apache/tomcat/lite/HexDump.java Mon Nov 9 21:00:22 2009 @@ -33,7 +33,7 @@ // -------------------------------------------------------------- Constants - static StringManager sm; + static final StringManager sm; /** * Table for HEX to DEC byte translation. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org