Author: markt
Date: Tue Nov 17 20:48:15 2009
New Revision: 881499
URL: http://svn.apache.org/viewvc?rev=881499&view=rev
Log:
Test some edge cases with = in cookie values (current code fails these tests -
patch to follow shortly)
Modified:
tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesAllowEquals.java
Modified:
tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesAllowEquals.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesAllowEquals.java?rev=881499&r1=881498&r2=881499&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesAllowEquals.java
(original)
+++ tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesAllowEquals.java
Tue Nov 17 20:48:15 2009
@@ -31,7 +31,9 @@
public class TestCookiesAllowEquals extends TomcatBaseTest{
- private static final String COOKIE_WITH_EQUALS = "name=value=withequals";
+ private static final String COOKIE_WITH_EQUALS_1 = "name=equals=middle";
+ private static final String COOKIE_WITH_EQUALS_2 = "name==equalsstart";
+ private static final String COOKIE_WITH_EQUALS_3 = "name=equalsend=";
public void testWithEquals() throws Exception {
System.setProperty(
@@ -59,7 +61,9 @@
String[] request = new String[1];
request[0] =
"GET /test HTTP/1.0" + CRLF +
- "Cookie: " + COOKIE_WITH_EQUALS + CRLF + CRLF;
+ "Cookie: " + COOKIE_WITH_EQUALS_1 + CRLF +
+ "Cookie: " + COOKIE_WITH_EQUALS_2 + CRLF +
+ "Cookie: " + COOKIE_WITH_EQUALS_3 + CRLF + CRLF;
setRequest(request);
processRequest(true); // blocks until response has been read
String response = getResponseBody();
@@ -68,7 +72,8 @@
disconnect();
reset();
tomcat.stop();
- assertEquals(COOKIE_WITH_EQUALS, response);
+ assertEquals(COOKIE_WITH_EQUALS_1 + COOKIE_WITH_EQUALS_2 +
+ COOKIE_WITH_EQUALS_3, response);
}
@Override
@@ -89,7 +94,7 @@
Cookie cookies[] = req.getCookies();
for (Cookie cookie : cookies) {
resp.getWriter().write(cookie.getName() + "=" +
- cookie.getValue() + "\n");
+ cookie.getValue());
}
resp.flushBuffer();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
