2009/12/22 Remy Maucherat <r...@apache.org>: > On Mon, 2009-12-21 at 21:51 +0000, kkoli...@apache.org wrote: >> Author: kkolinko >> Date: Mon Dec 21 21:51:29 2009 >> New Revision: 893001 >> >> URL: http://svn.apache.org/viewvc?rev=893001&view=rev >> Log: >> Fix second part of Comment 8 in >> https://issues.apache.org/bugzilla/show_bug.cgi?id=47413#c8 >> Coerce result of composite EL expression (${a}${b}) from String to the >> expected type. > > If that really mandatory ? > (if it is, I don't think it is that great to add it in Generator)
Expression Language Specification, Version 2.1 jsp-2_1-fr-spec-el.pdf, page 20 of 122, ch. 1.2.3 Composite expressions: "Once evaluated, the resulting String is then coerced to the expected type," "according to the EL type conversion rules." I have a sample JSP page demonstrating it committed to trunk in http://svn.apache.org/viewvc?rev=892968&view=rev I would very like this issue to fixed in the release. > (if it is, I don't think it is that great to add it in Generator) What do you mean? To move the code, added by this patch, to JspUtil? I should say a thing about this patch: It adds a call to "org.apache.el.lang.ELSupport.coerceToType" into the generated JSP java code. This is outstanding, because previously all generated code was calling JspRuntimeLibrary class, and now it accesses ELSupport directly. When I first discussed this issue, [1] I thought that such call won't be allowed by our package access restrictions. Actually it is allowed. Though maybe I still should make a proxy method for it in JspRuntimeLibrary class? [1] http://markmail.org/thread/q3xobx73n5bwqarx > > Also, an earlier issue: I see void was added as a return type in > JspUtil, but this does not look correct to me. > > Rémy > Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
