https://issues.apache.org/bugzilla/show_bug.cgi?id=48701
Konstantin Kolinko <knst.koli...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|INVALID |
Severity|major |regression
--- Comment #5 from Konstantin Kolinko <knst.koli...@gmail.com> 2010-02-15
17:14:25 UTC ---
Reopening.
Reviewing implementation of o.a.j.compiler.ScriptingVariabler and what the
specification says about objects, scripting variables, and introducing them:
1. In Tomcat code we make no distinction between variables declared
programmatically (through VariableInfo) and through TLD (TagVariableInfo).
Both introduce a java language variable (aka scripting variable) in the
generated code.
>From JSP.7.1.2 of JSP/2.2 spec:
"Finally, the XML document is processed to create a JSP page implementation
class. This process may involve creating scripting variables. Each custom
action
will provide information about variables, either statically in the TLD, or more
flexibly by using the getVariableInfo method of a TagExtraInfo class."
- both ways introduce a variable
2. About the wording of JSP.5.3 I think that
There is no explicit requirement in the Spec to use TagVariableInfo to
implement variables introduced through TLD at the time when we are generating
the servlet code. Thus I think the spec mentions VariableInfo in JSP.5.3,
making no distinction. Also maybe the wording was remained intact since
JSP/1.1, and variable declarations in TLDs were introduced in JSP/1.2.
The place to fix this issue would be
Generator#GeneratorVisitor#visit(Node.CustomTag)
- see "JSP.5.3" mentioned in a comment there
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
