2010/2/17 Mark Thomas <[email protected]>:
> On 16/02/2010 21:24, Konstantin Kolinko wrote:
>> 2010/2/16 Konstantin Kolinko <[email protected]>:
>>> 2010/2/16 <[email protected]>:
>>>> Author: markt
>>>> Date: Tue Feb 16 18:39:08 2010
>>>> New Revision: 910644
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=910644&view=rev
>>>> Log:
>>>> Proposal
>>>>
>>>> Modified:
>>>> tomcat/tc6.0.x/trunk/STATUS.txt
>>>>
>>>
>>>> +
>>>> +* Various manifest improvements
>>>> +
>>>> http://people.apache.org/~markt/patches/2010-02-16-manifest-improvements.patch
>>>> + +1: markt
>>>> + -1:
>>>
>>
>> 1. Why annotations-api.jar.manifest starts with "Name: javax/servlet/ " ?
>
> Because the definitions come from the Servlet spec and I couldn't come
> up with a better name. Suggestions welcome.
I'll think about that.
For starters, we can remove the "Name:",
so that that title applies to the jar as a whole.
Going into details,
I see that SRV.14.5 says that it "expands on the
Java EE 5 specification section 5 titled “Resources, Naming, and Injection.”"
javax/annotation/
are JSR 250 Common Annotations for the Java™ Platform™
javax/ejb/
are from JSR 220 Enterprise JavaBeansTM 3.0
javax/persistence/
are from JSR 220 Enterprise JavaBeansTM 3.0
javax/xml/ws/
are from JSR 224 JavaTM API for XML-Based Web Services (JAX-WS) 2.0
>
>> 2. el-api.jar contains unfiltered @el.revision@ in its manifest
>
> I'll fix that.
>
Replace
+ <filter token="jsp.revision" value="${el.revision}"/>
with
+ <filter token="el.revision" value="${el.revision}"/>
>> 3. If you build extras after building tomcat, all files in extras
>>
>> extras\catalina-jmx-remote.jar
>> extras\catalina-ws.jar
>> extras\tomcat-juli.jar
>> extras\tomcat-juli-adapters.jar
>>
>> contain unfiltered \META-INF\NOTICE with a @YEAR@
>
> And I thought I fixed that. I'll check. I modified my patch shortly
> after I proposed it. Did you get the modified version?
The current version is the same as the one that I applied.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
