Author: markt
Date: Tue Mar 9 15:01:05 2010
New Revision: 920907
URL: http://svn.apache.org/viewvc?rev=920907&view=rev
Log:
Review feedback
1. getNameFromAttribute() returns the attribute name, not the variable name and
2. This is a translation time test so the attribute value is not known
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Generator.java?rev=920907&r1=920906&r2=920907&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/jasper/compiler/Generator.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Tue Mar 9
15:01:05 2010
@@ -1725,11 +1725,10 @@ class Generator {
for (int i = 0; i < tagInfos.length; i++) {
TagVariableInfo tagInfo = tagInfos[i];
if (tagInfo != null) {
- String name = tagInfo.getNameFromAttribute();
- if (name == null) {
- name = tagInfo.getNameGiven();
+ String name = tagInfo.getNameGiven();
+ if (name != null) {
+ pageInfo.getVarInfoNames().add(name);
}
- pageInfo.getVarInfoNames().add(name);
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
