On 04/14/2010 07:07 AM, Konstantin Kolinko wrote:
2010/4/13 Filip Hanik - Dev Lists<devli...@hanik.com>:
This makes zero sense and I would do a -1 on this commit and the bug in
general.
What effectively has happened here is that there has been a public API
change without any justification.
Since this is a mutable field, you've now made it non mutable. and in there
lies the change.
I am +1 on the change.
doesn't change a veto
If we need it configurable, let's define a system property to
initialize its value at startup,
I agree, however that was not done in the original commit.
or better to define an instance field somewhere.
again, I agree. If you're gonna change the API, do it right. Let's not
make variables "final" cause it's someone preference
It makes no sense for me to flip between "secure random" and "insecure
random" at runtime.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
