https://issues.apache.org/bugzilla/show_bug.cgi?id=49234
--- Comment #4 from Mark Thomas <ma...@apache.org> 2010-05-05 05:06:20 EDT --- Thanks for the updated patches. The o.a.catalina patch still needs a little work. It makes more changes than it needs to. The net effect of the patch is to make Role.rolename and User.groups read-only. Only those changes should be present in the patch file. The changes that change the order of the attributes need to be removed (attributes are currently in alphabetical order and should stay that way). For the o.a.c.connector patch, the initialized attribute was removed in r940008. As far as possible, patches should be aligned with the code at the point of submission. It is easy to drop a section of a patch so I have applied this patch less that one new attribute. In terms of approach for handling the ProtocolHandlers, that is worth a discussion on the dev list. I suggest you write an e-mail that outlines the different options. If you think one option is better than the rest then include that in the e-mail along with why you think it is better. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
