Author: markt
Date: Tue May 18 19:43:44 2010
New Revision: 945843

URL: http://svn.apache.org/viewvc?rev=945843&view=rev
Log:
Proposal in response to a review comment

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=945843&r1=945842&r2=945843&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue May 18 19:43:44 2010
@@ -57,10 +57,10 @@ PATCHES PROPOSED TO BACKPORT:
   +1: markt, kkolinko
   -1: 
 
-  rjung: It seems we add roles to the user's role list in
-  getRoles(DirContext context, User user) every time it is
-  being called, if either commonRole is used or roleFormat / roleName?
-  I think we shouldn't change the original list, but instead a copy?
+* Make user's role list immutable. Modify a copy in getRoles(DirContext, User)
+  http://svn.apache.org/viewvc?rev=945841&view=rev
+  +1: markt
+  -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48701
   Take account of TagVariableInfo when implementing the rules of JSP.5.3



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to