On 06/07/2010 12:40, [email protected] wrote:
Author: kkolinko
Date: Tue Jul  6 10:40:16 2010
New Revision: 960864

URL: http://svn.apache.org/viewvc?rev=960864&view=rev
Log:
vote

Modified:
     tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=960864&r1=960863&r2=960864&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Jul  6 10:40:16 2010
@@ -154,11 +154,14 @@ PATCHES PROPOSED TO BACKPORT:
  * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49551
    Allow default context.xml file to be specified using an absolute path
    http://svn.apache.org/viewvc?rev=960701&view=rev
-  +1: markt
+  +1: markt, kkolinko
    -1:

  * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49217
    Prevent use of Java keywords in EL identifiers
    http://svn.apache.org/viewvc?rev=960711&view=rev
    +1: markt
-  -1:
+  -1: kkolinko: r960711 is a testcase, the fix is in r960712
+   Regarding r960712 I am -1 because 1) the list of reserved keywords must be 
shorter,
+   as I mentioned in Comment #3 for the issue and 2) it might break existing 
applications,
That analysis is not correct. Java identifier is defined by the Java language spec, not the EL spec.

+   so I think it must be possible to turn this check off.
Agreed. I'll propose a back-port with an option to disable once I have implemented all of the restrictions in the JLS.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to