On 19/07/2010 15:36, Konstantin Kolinko wrote: > 2010/7/19 Thomas Lee <thomas....@shinetech.com>: >> Hi all, >> >> I'm quite new to the Tomcat code base, so apologies if I'm asking a dumb >> question. >> >> I'm looking at: >> >> https://issues.apache.org/bugzilla/show_bug.cgi?id=49591 >> >> I've hit a dead-end in the Subversion history trying to track down why the >> flushBuffer() call was ever added to StandardHostValve.status(...): >> >> http://svn.apache.org/viewvc?view=revision&revision=389146 >> >> It seems like this stuff was copied or imported from elsewhere ("Attempt to >> create a new repository according to the earlier thread."), but I can't see >> any indication of where it was copied *from* so I'm struggling to follow the >> svn history. >> >> Can anybody shed some light on this so that I might continue digging through >> svn? > > My understanding is that because there was a decision to reorganize > source code layout when starting TC6 development, that was the easy > way to to that: > > BTW, it was before I came to the project and so I am not a witness. > > > Go to 5.5.x sources and restart from there. Note, that layout was a > bit different at that time. What are now subdirectories of > tc5.5.x/trunk (build, connectors, container, jasper, servletapi) were > separate projects in the repository. > > http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/?pathrev=389146 > > > Digging further, the code was added to StandardHostValve in rev.302028 > by moving it there from /valves/ErrorDispatcherValve class. > > http://svn.apache.org/viewvc?view=revision&revision=302028 > > The first revision of ErrorDispatcherValve (r.301082, 8 years ago) > already has the flushBuffer() code, and r.301077 is where cvs2svn > import of /container/catalina has started.
Diggin back into Tomcat 3 (before my time) it looks like the previous implementation was this: http://svn.apache.org/viewvc/tomcat/archive/tc3.3.x/trunk/container/src/share/org/apache/tomcat/modules/generators/ErrorHandler.java?view=log Getting back to the original question, I can't think why the call was added. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
