<ma...@apache.org> wrote in message
news:20100728155830.a602f2388...@eris.apache.org...
Author: markt
Date: Wed Jul 28 15:58:30 2010
New Revision: 980106
URL: http://svn.apache.org/viewvc?rev=980106&view=rev
Log:
Only download Checkstyle if it is going to be used
Add note the Checkstyle is LGPL
Add option (off by default) to fail test target as soon as one test fails.
Thanks.
Gump is now set up to nag the list if any checkstyle rules are failing (just
as it is doing for unit tests).
Modified:
tomcat/trunk/build.properties.default
tomcat/trunk/build.xml
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=980106&r1=980105&r2=980106&view=diff
==============================================================================
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Wed Jul 28 15:58:30 2010
@@ -32,11 +32,13 @@ version.patch=0
version.suffix=-dev
# ----- Build control flags -----
+# Note enabling validation uses Checkstyle which is LGPL licensed
execute.validate=false
execute.test.bio=true
execute.test.nio=true
# Still requires APR/native library to be present
execute.test.apr=true
+test.haltonfailure=false
# ----- Default Base Path for Dependent Packages -----
# Please note this path must be absolute, not relative,
Modified: tomcat/trunk/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=980106&r1=980105&r2=980106&view=diff
==============================================================================
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Wed Jul 28 15:58:30 2010
@@ -997,9 +997,11 @@
<!-- If test.entry is defined, run a single test, otherwise run
all valid tests -->
<test todir="${tomcat.build}/logs" name="${test.entry}"
if="test.entry"/>
- <batchtest todir="${tomcat.build}/logs" unless="test.entry"
- errorproperty="test.result.error"
failureproperty="test.result.failure"
- >
+ <batchtest todir="${tomcat.build}/logs"
+ unless="test.entry"
+ errorproperty="test.result.error"
+ failureproperty="test.result.failure"
+ haltonfailure="${test.haltonfailure}">
<fileset dir="test" >
<!-- Include all by default -->
<include name="**/Test*.java" />
@@ -1911,7 +1913,8 @@ Apache Tomcat ${version} native binaries
<!-- ================ Download and dependency building
=================== -->
<target name="download-validate"
- description="Download components necessary to validate source"
>
+ description="Download components necessary to validate source"
+ if="${execute.validate}">
<antcall target="downloadzip">
<param name="sourcefile" value="${checkstyle.loc}"/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
